[llvm] r213892 - [X86] Optimize stackmap shadows on X86.

Philip Reames listmail at philipreames.com
Thu Jul 24 15:01:59 PDT 2014

On 07/24/2014 02:41 PM, Chandler Carruth wrote:
> On Thu, Jul 24, 2014 at 2:36 PM, Philip Reames 
> <listmail at philipreames.com <mailto:listmail at philipreames.com>> wrote:
>     Was there a review thread for this I missed?  I would have liked
>     to see this before it went in.
> I'm curious, why?
This is touching code I care about and need to manage merges with. I'd 
rather not see unnecessary churn in tree if it can be avoided.

> Lang has touched the stack map code several times before, and has 
> touched other parts of the other backend plenty of times. It seems 
> plausible that this fell into what he felt was "obvious" enough for 
> post-commit review. I'd like to understand what about this you feel is 
> sufficiently non-obvious to really need pre-commit review. (I can 
> imagine possibilities, but that usually isn't wise...)
Ah, it seems I wasn't careful enough about my wording.

I was NOT trying to say this should have been pre-reviewed.

I was trying to ask a honest question: did I miss a review thread? If 
so, I need to update my filters to highlight it.  If it was reviewed, I 
would have liked to have seen it.  This is not the same as saying it 
should have been prereviewed.

Chandler, thanks for pointing out how my wording could be interpreted.  
Lang, sorry if my wording seemed to imply criticism.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/6b691da3/attachment.html>

More information about the llvm-commits mailing list