<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 07/24/2014 02:41 PM, Chandler
Carruth wrote:<br>
</div>
<blockquote
cite="mid:CAGCO0Kh3_1duNA2zcdHGxdLAKpMS8K4NKEk+VeXf2mAtYCSeUA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Jul 24, 2014 at 2:36 PM,
Philip Reames <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Was
there a review thread for this I missed? I would have
liked to see this before it went in.</blockquote>
</div>
<br>
I'm curious, why?</div>
</div>
</blockquote>
This is touching code I care about and need to manage merges with.
I'd rather not see unnecessary churn in tree if it can be avoided.<br>
<br>
<blockquote
cite="mid:CAGCO0Kh3_1duNA2zcdHGxdLAKpMS8K4NKEk+VeXf2mAtYCSeUA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
</div>
<div class="gmail_extra">Lang has touched the stack map code
several times before, and has touched other parts of the other
backend plenty of times. It seems plausible that this fell
into what he felt was "obvious" enough for post-commit review.
I'd like to understand what about this you feel is
sufficiently non-obvious to really need pre-commit review. (I
can imagine possibilities, but that usually isn't wise...)</div>
</div>
</blockquote>
Ah, it seems I wasn't careful enough about my wording. <br>
<br>
I was NOT trying to say this should have been pre-reviewed. <br>
<br>
I was trying to ask a honest question: did I miss a review thread?
If so, I need to update my filters to highlight it. If it was
reviewed, I would have liked to have seen it. This is not the same
as saying it should have been prereviewed. <br>
<br>
Chandler, thanks for pointing out how my wording could be
interpreted. Lang, sorry if my wording seemed to imply criticism.
<br>
<br>
Philip<br>
<br>
</body>
</html>