[PATCH][TableGen] Allow shift operators to take bits<n>

[Adam Nemet]

Hal,

This is much appreciated.  There were 4 other patches dependent on this.  Committed as r213277.

Thanks,
Adam
 
On Jul 17, 2014, at 7:19 AM, Hal Finkel <hfinkel at anl.gov> wrote:

> ----- Original Message -----
>> From: "Adam Nemet" <anemet at apple.com>
>> To: "llvm-commits" <llvm-commits at cs.uiuc.edu>
>> Sent: Wednesday, July 16, 2014 7:51:42 PM
>> Subject: [PATCH][TableGen] Allow shift operators to take bits<n>
>> 
>> 
>> 
>> Convert the operand to int if possible, i.e. if the value is properly
>> initialized. (I suppose there is further room for improvement here to
>> also
>> perform the shift if the uninitialized bits are shifted out.)
>> 
>> With this little change we can now compute the scaling factor for
>> compressed
>> displacement with pure tablegen code in the X86 backend. This is
>> useful
>> because both the X86-disassembler-specific part of tablegen and the
>> assembler
>> need this and TD is the natural sharing place.
>> 
>> The patch also adds the missing documentation for the shift and add
>> operator.
>> 
>> Does this look good?
> 
> LGTM. Thanks!
> 
> -Hal
> 
>> 
>> Thanks,
>> Adam
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> -- 
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140717/2c9ef74b/attachment.html>