<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hal,<div><br></div><div>This is much appreciated. There were 4 other patches dependent on this. Committed as r213277.</div><div><br></div><div>Thanks,</div><div>Adam</div><div> <br><div><div>On Jul 17, 2014, at 7:19 AM, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">----- Original Message -----<br><blockquote type="cite">From: "Adam Nemet" <<a href="mailto:anemet@apple.com">anemet@apple.com</a>><br>To: "llvm-commits" <<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br>Sent: Wednesday, July 16, 2014 7:51:42 PM<br>Subject: [PATCH][TableGen] Allow shift operators to take bits<n><br><br><br><br>Convert the operand to int if possible, i.e. if the value is properly<br>initialized. (I suppose there is further room for improvement here to<br>also<br>perform the shift if the uninitialized bits are shifted out.)<br><br>With this little change we can now compute the scaling factor for<br>compressed<br>displacement with pure tablegen code in the X86 backend. This is<br>useful<br>because both the X86-disassembler-specific part of tablegen and the<br>assembler<br>need this and TD is the natural sharing place.<br><br>The patch also adds the missing documentation for the shift and add<br>operator.<br><br>Does this look good?<br></blockquote><br>LGTM. Thanks!<br><br>-Hal<br><br><blockquote type="cite"><br>Thanks,<br>Adam<br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br></blockquote><br>--<span class="Apple-converted-space"> </span><br>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory</div></blockquote></div><br></div></body></html>