[PATCH] [AArch64] Add logical pseudo instructions to MC AsmParser

Arnaud Allard de Grandmaison arnaud.adegm at gmail.com
Thu Jul 10 08:24:11 PDT 2014

Commited @ r212722.

FYI, I have another alias related patch brewing --- for add & sub.

Thanks Tim !

Arnaud A. de Grandmaison

On Thu, Jul 10, 2014 at 5:03 PM, Tim Northover <t.p.northover at gmail.com>

> Hi Arnaud,
> > I had to move it from ouside of the multiclass, to where it is used
> inside
> > the multiclass, because InstAlias does not have those. As you point, the
> > alias have no codegen pattern.
> Ah, sorry. I missed that.
> > I have not changed the functionality there, so no additionnal .ll test is
> > necessary -- I think.
> Agreed. You were quite right the first time.
> > By the way, this could applies in many places around. If you believe it
> is
> > worth, than I can fix those other places (and refactor a bit) in a
> separate
> > patch. This would make the code more readable.
> That'd be great if you're willing! No need to ask for review for
> something that simple (depending on quite what you mean by "refactor"
> of course).
> > I attached the updated patch. I left the fixme note in
> > basic-a64-diagnostics; I will remove it before committing if you think we
> > just don't care. I also changed pseudo to alias in the commit message or
> > comments.
> I think this patch looks good (either way with the FIXME). Thanks for
> updating it.
> Tim.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140710/e829fa64/attachment.html>

More information about the llvm-commits mailing list