[PATCH] [AArch64] Add logical pseudo instructions to MC AsmParser

Tim Northover t.p.northover at gmail.com
Thu Jul 10 08:03:21 PDT 2014

Hi Arnaud,

> I had to move it from ouside of the multiclass, to where it is used inside
> the multiclass, because InstAlias does not have those. As you point, the
> alias have no codegen pattern.

Ah, sorry. I missed that.

> I have not changed the functionality there, so no additionnal .ll test is
> necessary -- I think.

Agreed. You were quite right the first time.

> By the way, this could applies in many places around. If you believe it is
> worth, than I can fix those other places (and refactor a bit) in a separate
> patch. This would make the code more readable.

That'd be great if you're willing! No need to ask for review for
something that simple (depending on quite what you mean by "refactor"
of course).

> I attached the updated patch. I left the fixme note in
> basic-a64-diagnostics; I will remove it before committing if you think we
> just don't care. I also changed pseudo to alias in the commit message or
> comments.

I think this patch looks good (either way with the FIXME). Thanks for
updating it.


More information about the llvm-commits mailing list