[PATCH] ARMEB: Vector extend operations

James Molloy james.molloy at arm.com
Thu Jun 12 06:29:19 PDT 2014


Hi Konrad,

No, I don't think so. As I mentioned in my previous review comment, I would like to see more explanations in the code and commit message before I'm happy.

Also, I believe you're actually editing the code that generates this VLDR/VREV pair now. So I think that for 64-bit to 128-bit vector extloads, you can just use the little-endian version, not predicate it, and make little-endian generate an LD1 instead of a LDR.

Also, I take it this affects AArch64 too?

Cheers,

James

http://reviews.llvm.org/D4043






More information about the llvm-commits mailing list