[PATCH] [InstructionMerge - GVN] hoisting and sinking of equivalent memory instructions in diamonds

Gerolf Hoflehner ghoflehner at apple.com
Mon Jun 9 20:42:38 PDT 2014

Alright, time has come to move on with this one. The instruction merge code is now a pass eagerly awaiting  expert review eyes.


On May 2, 2014, at 5:13 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Fri, May 2, 2014 at 4:44 PM, Gerolf Hoflehner <ghoflehner at apple.com> wrote:
> I can see the arguments pro independent pass, but why do you assert it will make the code much easier to review? The code is coherent as it is and won’t change whether it is  part of GVN or its own phase. 
> Because then I don't have to even think about GVN? Anyways, it should be *much* easier to test.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140609/3638f0db/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: instruction_merge.patch
Type: application/octet-stream
Size: 26271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140609/3638f0db/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140609/3638f0db/attachment-0001.html>

More information about the llvm-commits mailing list