[compiler-rt] r210257 - [asan] Add 'asan' to asan test deps.

Alexey Samsonov vonosmas at gmail.com
Thu Jun 5 13:39:34 PDT 2014


Hi,

I think this patch is wrong.

On Thu, Jun 5, 2014 at 5:31 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com>
wrote:

> Author: eugenis
> Date: Thu Jun  5 07:31:22 2014
> New Revision: 210257
>
> URL: http://llvm.org/viewvc/llvm-project?rev=210257&view=rev
> Log:
> [asan] Add 'asan' to asan test deps.
>
> This sound like a good idea in general.
> Also, without this on Android we get add_lit_testsuite() with empty DEPENDS
> list, and it does not work well.
>
> Modified:
>     compiler-rt/trunk/test/asan/CMakeLists.txt
>
> Modified: compiler-rt/trunk/test/asan/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/CMakeLists.txt?rev=210257&r1=210256&r2=210257&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/test/asan/CMakeLists.txt (original)
> +++ compiler-rt/trunk/test/asan/CMakeLists.txt Thu Jun  5 07:31:22 2014
> @@ -96,7 +96,7 @@ if(COMPILER_RT_INCLUDE_TESTS)
>      ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg)
>  endif()
>
> -set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
> +set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS} asan)
>  if(NOT COMPILER_RT_STANDALONE_BUILD)
>    list(APPEND ASAN_TEST_DEPS asan)
>

asan *is* already added to the lit tests dependencies, in a non-standalone
compiler-rt build. It is not, and should not
be added to the deps in a standalone build. If you're running a
non-standalone build, they you have to build fresh Clang
and fresh runtime and use them to run tests. If you're using a standalone
build to run a test-suite, you are testing a
complete toolchain, which should just work.


>  endif()
>




>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140605/9d49e53f/attachment.html>


More information about the llvm-commits mailing list