<div dir="ltr"><div class="gmail_extra">Hi,</div><div class="gmail_extra"><br></div><div class="gmail_extra">I think this patch is wrong.<br><br><div class="gmail_quote">On Thu, Jun 5, 2014 at 5:31 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: eugenis<br>
Date: Thu Jun  5 07:31:22 2014<br>
New Revision: 210257<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210257&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210257&view=rev</a><br>
Log:<br>
[asan] Add 'asan' to asan test deps.<br>
<br>
This sound like a good idea in general.<br>
Also, without this on Android we get add_lit_testsuite() with empty DEPENDS<br>
list, and it does not work well.<br>
<br>
Modified:<br>
    compiler-rt/trunk/test/asan/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/test/asan/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/CMakeLists.txt?rev=210257&r1=210256&r2=210257&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/CMakeLists.txt?rev=210257&r1=210256&r2=210257&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/test/asan/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/test/asan/CMakeLists.txt Thu Jun  5 07:31:22 2014<br>
@@ -96,7 +96,7 @@ if(COMPILER_RT_INCLUDE_TESTS)<br>
     ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg)<br>
 endif()<br>
<br>
-set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})<br>
+set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS} asan)<br>
 if(NOT COMPILER_RT_STANDALONE_BUILD)<br>
   list(APPEND ASAN_TEST_DEPS asan)<br></blockquote><div><br></div><div>asan *is* already added to the lit tests dependencies, in a non-standalone compiler-rt build. It is not, and should not</div><div>be added to the deps in a standalone build. If you're running a non-standalone build, they you have to build fresh Clang</div>
<div>and fresh runtime and use them to run tests. If you're using a standalone build to run a test-suite, you are testing a</div><div>complete toolchain, which should just work.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

 endif()<br></blockquote><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div>
</div></div>