[llvm] r210182 - [AArch64] clang-format the load/store optimizer.

Daniel Jasper djasper at google.com
Wed Jun 4 06:47:02 PDT 2014


This is also something we want to fix: llvm.org/PR16535.. We just haven't
had time to get on that yet.


On Wed, Jun 4, 2014 at 3:31 PM, James Molloy <james.molloy at arm.com> wrote:

> Hi Tilmann,
>
> We try not to run clang-format on full source files, because it messes up
> the SVN blame history. In fact, the changes clang-format has made here
> don't
> really make sense - the switch was more readable initially.
>
> Could you please revert at least the switch part?
>
> Cheers,
>
> James
>
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Tilmann Scheller
> > Sent: 04 June 2014 13:41
> > To: llvm-commits at cs.uiuc.edu
> > Subject: [llvm] r210182 - [AArch64] clang-format the load/store
> optimizer.
> >
> > Author: tilmann
> > Date: Wed Jun  4 07:40:35 2014
> > New Revision: 210182
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=210182&view=rev
> > Log:
> > [AArch64] clang-format the load/store optimizer.
> >
> > No change in functionality.
> >
> > Modified:
> >     llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
> >
> > Modified: llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
> > URL: http://llvm.org/viewvc/llvm-
> >
> project/llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp?rev=21
> > 0182&r1=210181&r2=210182&view=diff
> >
> ==========================================================================
> > ====
> > --- llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
> (original)
> > +++ llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp Wed Jun
>  4
> > 07:40:35 2014
> > @@ -40,14 +40,13 @@ STATISTIC(NumPreFolded, "Number of pre-i
> >  STATISTIC(NumUnscaledPairCreated,
> >            "Number of load/store from unscaled generated");
> >
> > -static cl::opt<unsigned> ScanLimit("aarch64-load-store-scan-limit",
> > cl::init(20),
> > -                                   cl::Hidden);
> > +static cl::opt<unsigned> ScanLimit("aarch64-load-store-scan-limit",
> > +                                   cl::init(20), cl::Hidden);
> >
> >  // Place holder while testing unscaled load/store combining
> > -static cl::opt<bool>
> > -EnableAArch64UnscaledMemOp("aarch64-unscaled-mem-op", cl::Hidden,
> > -                         cl::desc("Allow AArch64 unscaled load/store
> > combining"),
> > -                         cl::init(true));
> > +static cl::opt<bool> EnableAArch64UnscaledMemOp(
> > +    "aarch64-unscaled-mem-op", cl::Hidden,
> > +    cl::desc("Allow AArch64 unscaled load/store combining"),
> > cl::init(true));
> >
> >  namespace {
> >  struct AArch64LoadStoreOpt : public MachineFunctionPass {
> > @@ -217,16 +216,26 @@ static unsigned getPreIndexedOpcode(unsi
> >    switch (Opc) {
> >    default:
> >      llvm_unreachable("Opcode has no pre-indexed equivalent!");
> > -  case AArch64::STRSui:    return AArch64::STRSpre;
> > -  case AArch64::STRDui:    return AArch64::STRDpre;
> > -  case AArch64::STRQui:    return AArch64::STRQpre;
> > -  case AArch64::STRWui:    return AArch64::STRWpre;
> > -  case AArch64::STRXui:    return AArch64::STRXpre;
> > -  case AArch64::LDRSui:    return AArch64::LDRSpre;
> > -  case AArch64::LDRDui:    return AArch64::LDRDpre;
> > -  case AArch64::LDRQui:    return AArch64::LDRQpre;
> > -  case AArch64::LDRWui:    return AArch64::LDRWpre;
> > -  case AArch64::LDRXui:    return AArch64::LDRXpre;
> > +  case AArch64::STRSui:
> > +    return AArch64::STRSpre;
> > +  case AArch64::STRDui:
> > +    return AArch64::STRDpre;
> > +  case AArch64::STRQui:
> > +    return AArch64::STRQpre;
> > +  case AArch64::STRWui:
> > +    return AArch64::STRWpre;
> > +  case AArch64::STRXui:
> > +    return AArch64::STRXpre;
> > +  case AArch64::LDRSui:
> > +    return AArch64::LDRSpre;
> > +  case AArch64::LDRDui:
> > +    return AArch64::LDRDpre;
> > +  case AArch64::LDRQui:
> > +    return AArch64::LDRQpre;
> > +  case AArch64::LDRWui:
> > +    return AArch64::LDRWpre;
> > +  case AArch64::LDRXui:
> > +    return AArch64::LDRXpre;
> >    }
> >  }
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140604/5eab001c/attachment.html>


More information about the llvm-commits mailing list