<div dir="ltr">This is also something we want to fix: <a href="http://llvm.org/PR16535">llvm.org/PR16535</a>.. We just haven't had time to get on that yet.</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Jun 4, 2014 at 3:31 PM, James Molloy <span dir="ltr"><<a href="mailto:james.molloy@arm.com" target="_blank">james.molloy@arm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Tilmann,<br>
<br>
We try not to run clang-format on full source files, because it messes up<br>
the SVN blame history. In fact, the changes clang-format has made here don't<br>
really make sense - the switch was more readable initially.<br>
<br>
Could you please revert at least the switch part?<br>
<br>
Cheers,<br>
<br>
James<br>
<div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-">llvm-commits-</a><br>
> <a href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Tilmann Scheller<br>
> Sent: 04 June 2014 13:41<br>
> To: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> Subject: [llvm] r210182 - [AArch64] clang-format the load/store optimizer.<br>
><br>
> Author: tilmann<br>
> Date: Wed Jun 4 07:40:35 2014<br>
> New Revision: 210182<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210182&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210182&view=rev</a><br>
> Log:<br>
> [AArch64] clang-format the load/store optimizer.<br>
><br>
> No change in functionality.<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp?rev=21<br>
> 0182&r1=210181&r2=210182&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp (original)<br>
> +++ llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp Wed Jun 4<br>
> 07:40:35 2014<br>
> @@ -40,14 +40,13 @@ STATISTIC(NumPreFolded, "Number of pre-i<br>
> STATISTIC(NumUnscaledPairCreated,<br>
> "Number of load/store from unscaled generated");<br>
><br>
> -static cl::opt<unsigned> ScanLimit("aarch64-load-store-scan-limit",<br>
> cl::init(20),<br>
> - cl::Hidden);<br>
> +static cl::opt<unsigned> ScanLimit("aarch64-load-store-scan-limit",<br>
> + cl::init(20), cl::Hidden);<br>
><br>
> // Place holder while testing unscaled load/store combining<br>
> -static cl::opt<bool><br>
> -EnableAArch64UnscaledMemOp("aarch64-unscaled-mem-op", cl::Hidden,<br>
> - cl::desc("Allow AArch64 unscaled load/store<br>
> combining"),<br>
> - cl::init(true));<br>
> +static cl::opt<bool> EnableAArch64UnscaledMemOp(<br>
> + "aarch64-unscaled-mem-op", cl::Hidden,<br>
> + cl::desc("Allow AArch64 unscaled load/store combining"),<br>
> cl::init(true));<br>
><br>
> namespace {<br>
> struct AArch64LoadStoreOpt : public MachineFunctionPass {<br>
> @@ -217,16 +216,26 @@ static unsigned getPreIndexedOpcode(unsi<br>
> switch (Opc) {<br>
> default:<br>
> llvm_unreachable("Opcode has no pre-indexed equivalent!");<br>
> - case AArch64::STRSui: return AArch64::STRSpre;<br>
> - case AArch64::STRDui: return AArch64::STRDpre;<br>
> - case AArch64::STRQui: return AArch64::STRQpre;<br>
> - case AArch64::STRWui: return AArch64::STRWpre;<br>
> - case AArch64::STRXui: return AArch64::STRXpre;<br>
> - case AArch64::LDRSui: return AArch64::LDRSpre;<br>
> - case AArch64::LDRDui: return AArch64::LDRDpre;<br>
> - case AArch64::LDRQui: return AArch64::LDRQpre;<br>
> - case AArch64::LDRWui: return AArch64::LDRWpre;<br>
> - case AArch64::LDRXui: return AArch64::LDRXpre;<br>
> + case AArch64::STRSui:<br>
> + return AArch64::STRSpre;<br>
> + case AArch64::STRDui:<br>
> + return AArch64::STRDpre;<br>
> + case AArch64::STRQui:<br>
> + return AArch64::STRQpre;<br>
> + case AArch64::STRWui:<br>
> + return AArch64::STRWpre;<br>
> + case AArch64::STRXui:<br>
> + return AArch64::STRXpre;<br>
> + case AArch64::LDRSui:<br>
> + return AArch64::LDRSpre;<br>
> + case AArch64::LDRDui:<br>
> + return AArch64::LDRDpre;<br>
> + case AArch64::LDRQui:<br>
> + return AArch64::LDRQpre;<br>
> + case AArch64::LDRWui:<br>
> + return AArch64::LDRWpre;<br>
> + case AArch64::LDRXui:<br>
> + return AArch64::LDRXpre;<br>
> }<br>
> }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>