[llvm] r209907 - Fix MIPS exception personality encoding.

Logan Chien tzuhsiang.chien at gmail.com
Tue Jun 3 07:01:24 PDT 2014


Hi Daniel,

Sorry for committing without a LGTM.  I thought it was OK to commit since
there was no further discussion.  Sorry about this.

Sincerely,
Logan

On Tuesday, June 3, 2014, Logan Chien <tzuhsiang.chien at gmail.com
<javascript:_e(%7B%7D,'cvml','tzuhsiang.chien at gmail.com');>> wrote:

> Hi Joerg,
>
> Thanks for your review.
>
> Logan
>
> On Tuesday, June 3, 2014, Joerg Sonnenberger <joerg at britannica.bec.de>
> wrote:
>
>> On Tue, Jun 03, 2014 at 09:10:03AM +0000, Daniel Sanders wrote:
>> > Hi Logan,
>> >
>> > I know that you addressed Joerg's comments at
>> http://reviews.llvm.org/D3828 but I didn't see an LGTM (or words to that
>> effect) for this patch so I think it was still being reviewed when you
>> committed it.
>> >
>> > Joerg: Were you happy with the updated patch?
>>
>> Yes.
>>
>> Joerg
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140603/385db0a3/attachment.html>


More information about the llvm-commits mailing list