[PATCH] [ASan/Win] Don't crash when ASAN_OPTIONS have disable_core=1

Timur Iskhodzhanov timurrrr at google.com
Mon May 5 08:57:06 PDT 2014


Hi kcc,

http://reviews.llvm.org/D3610

Files:
  lib/asan/asan_rtl.cc
  lib/sanitizer_common/sanitizer_win.cc

Index: lib/asan/asan_rtl.cc
===================================================================
--- lib/asan/asan_rtl.cc
+++ lib/asan/asan_rtl.cc
@@ -178,7 +178,8 @@
 
   ParseFlag(str, &f->disable_core, "disable_core",
       "Disable core dumping. By default, disable_core=1 on 64-bit to avoid "
-      "dumping a 16T+ core file.");
+      "dumping a 16T+ core file. "
+      "Ignored on architectures that don't dump core by default.");
 
   ParseFlag(str, &f->allow_reexec, "allow_reexec",
       "Allow the tool to re-exec the program. This may interfere badly with "
Index: lib/sanitizer_common/sanitizer_win.cc
===================================================================
--- lib/sanitizer_common/sanitizer_win.cc
+++ lib/sanitizer_common/sanitizer_win.cc
@@ -185,7 +185,7 @@
 }
 
 void DisableCoreDumper() {
-  UNIMPLEMENTED();
+  // Do nothing.
 }
 
 void ReExec() {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3610.9079.patch
Type: text/x-patch
Size: 883 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140505/62a1702b/attachment.bin>


More information about the llvm-commits mailing list