[PATCH] Optimize long branch for MIPS64 by removing calculation of %higher and %highest

Mark Seaborn mseaborn at chromium.org
Tue Apr 15 14:44:27 PDT 2014


  @Sasa: You have confused me a bit by having interdependent changes in flight at the same time, which is why I've been slow coming back to this.

  When you post an updated patch in reply to a review, could you possibly reply to each of the review comments, even if it's just to say "Done"?

  I wrote "Is this change based on your not-yet-committed change? If so, presumably you should remove LONG_BRANCH_LUi64 too?".  Since the current version of the patch does remove LONG_BRANCH_LUi64, it looks like the answer to my first question was "yes", but it would be better if you answered directly, so that I don't have to deduce it from the change to the patch.

http://reviews.llvm.org/D3281






More information about the llvm-commits mailing list