[PATCH] Add ARM big endian Target (armeb, thumbeb)

Tim Northover t.p.northover at gmail.com
Fri Mar 28 09:23:00 PDT 2014

  Hi Christian,

  Two more issues I've spotted while looking at the diff:

  I think the LLVM-side testing is still insufficient. As far as I can tell, we could randomise your new getFixupKindContainerSizeBytes function with no adverse effects on "make check".

Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:105
@@ -103,1 +104,3 @@
+    const static MCFixupKindInfo InfosBE[ARM::NumTargetFixupKinds] = {
+// This table *must* be in the order that the fixup_* kinds are defined in
I also suspect this extra table isn't needed. ARM doesn't make use of the actual offset & size entries, leaving only a cosmetic effect on some of the comments output by llvm-mc.

It also has incorrect entries, even if it should exist (e.g. fixup_t2_movt_hi16 -- the 'i' bit, beyond 20, is affected by the fixup).


More information about the llvm-commits mailing list