[PATCH] Debug info: Support fragmented variables.

Adrian Prantl aprantl at apple.com
Fri Mar 21 15:49:21 PDT 2014

On Mar 20, 2014, at 2:18 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Mar 20, 2014 2:14 PM, "Adrian Prantl" <aprantl at apple.com> wrote:
> >
> > Hi Eric & Chandler,
> >
> > it’s been a while, and I was just thinking about what we could do to make this move forward a little faster. I understand that the more time is passing the patch grows larger and large which makes it harder to review.
> I'm confused as to why the patch would grow larger over time... But yes, prolonged review is expensive.

That meant more as a statement about the past than a prognosis for the future :-)

> > We could, for instance split out the SROA changes into a separate patch, and then focus on the IR and DwarfDebug changes initially, with the type legalizer providing the necessary test cases.
> If you can handcraft (or otherwise) it that is what you expect sroa to produce and demonstrate that CodeGen (DwarfDebug, etc) produces the right stuff - that seems good.

This is really just a matter of splitting out the existing testcases into multiple files. Currently they all have multiple RUN lines: one for opt, invoking sroa and FileCheck’ing the output, and one for llc, which compiles the output of the previous stage and then FileCheck’s the llvm-dwarfdump output.
> Assuming the ir format is easily agreed upon.

Yes, so that’s the part I am actually most interested in — Does anyone (looking mostly in echristo’s direction) have any concerns about the IR format or just not have time to look at it yet? Once we all agree on the IR then I’d really like to get the backend support into trunk as soon as possible and then work incrementally from there (adding support for other passes/datatypes/etc, …)


More information about the llvm-commits mailing list