[PATCH] Debug info: Support fragmented variables.
dblaikie at gmail.com
Thu Mar 20 14:18:02 PDT 2014
On Mar 20, 2014 2:14 PM, "Adrian Prantl" <aprantl at apple.com> wrote:
> Hi Eric & Chandler,
> it's been a while, and I was just thinking about what we could do to make
this move forward a little faster. I understand that the more time is
passing the patch grows larger and large which makes it harder to review.
I'm confused as to why the patch would grow larger over time... But yes,
prolonged review is expensive.
> We could, for instance split out the SROA changes into a separate patch,
and then focus on the IR and DwarfDebug changes initially, with the type
legalizer providing the necessary test cases.
If you can handcraft (or otherwise) it that is what you expect sroa to
produce and demonstrate that CodeGen (DwarfDebug, etc) produces the right
stuff - that seems good.
Assuming the ir format is easily agreed upon.
> On Mar 18, 2014, at 5:55 PM, Adrian Prantl <aprantl at apple.com> wrote:
> > Rebased on r204198.
> > Moved the DWARF expression output for DW_op_pieces out of
emitDebugLocEntry::emitDebugLocEntry() and into a DWARFPieceEmitter. Should
be more readable this way.
> > Hi #llvm,
> > http://llvm-reviews.chandlerc.com/D2680
> > CHANGE SINCE LAST DIFF
> > http://llvm-reviews.chandlerc.com/D2680?vs=7650&id=7931#toc
> > Files:
> > docs/SourceLevelDebugging.rst
> > include/llvm/CodeGen/AsmPrinter.h
> > include/llvm/CodeGen/MachineInstr.h
> > include/llvm/CodeGen/SelectionDAG.h
> > include/llvm/IR/DIBuilder.h
> > include/llvm/IR/DebugInfo.h
> > lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
> > lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> > lib/CodeGen/AsmPrinter/DwarfDebug.h
> > lib/CodeGen/AsmPrinter/DwarfUnit.cpp
> > lib/CodeGen/SelectionDAG/InstrEmitter.cpp
> > lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
> > lib/CodeGen/SelectionDAG/SelectionDAG.cpp
> > lib/IR/DIBuilder.cpp
> > lib/IR/DebugInfo.cpp
> > lib/Transforms/Scalar/SROA.cpp
> > test/DebugInfo/X86/dbg-large-unsigned-const.ll
> > test/DebugInfo/X86/pieces-1.ll
> > test/DebugInfo/X86/sdagsplit-1.ll
> > test/DebugInfo/X86/sdagsplit-2.ll
> > test/DebugInfo/X86/sroasplit-1.ll
> > test/DebugInfo/X86/sroasplit-2.ll
> > <D2680.7.patch>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits