[PATCH] Refactor lit.cfg to use lit.util.which

Robinson, Paul Paul_Robinson at playstation.sony.com
Fri Mar 21 10:39:09 PDT 2014

> Hi Paul,
> That looks fine to me, thanks.

Awesome, thanks.  r204486.
Patch for Clang's version coming soon.

> FWIW, I'm not really much of a fan of the current implementation
> (prior to your path), I would like it better if lit controlled
> more tightly exactly what executables were found and had a list
> of allowed directories (with exceptions, maybe) instead of a
> list of explicit tool names.
> - Daniel

I'll leave that particular minefield to you, thanks.

FYI the specific case we tripped over is that (a) we build cross
tools and rename them, and (b) 'not' isn't a lit primitive and
looks for programs to run too.  We didn't invent the scanning of
the command line, but we're taking advantage of it to bury the
renaming checks inside our version of lit.util.which, so that
both lit and 'not' will do the right thing.


More information about the llvm-commits mailing list