[PATCH] Refactor lit.cfg to use lit.util.which

Daniel Dunbar daniel at zuster.org
Thu Mar 20 08:11:00 PDT 2014


Hi Paul,

That looks fine to me, thanks.

FWIW, I'm not really much of a fan of the current implementation (prior to
your path), I would like it better if lit controlled more tightly exactly
what executables were found and had a list of allowed directories (with
exceptions, maybe) instead of a list of explicit tool names.

 - Daniel


On Wed, Mar 19, 2014 at 3:34 PM, Robinson, Paul <
Paul_Robinson at playstation.sony.com> wrote:

> Ping*3.
>
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> > Sent: Wednesday, March 12, 2014 2:37 PM
> > To: llvm-commits at cs.uiuc.edu commits (llvm-commits at cs.uiuc.edu);
> > daniel at zuster.org
> > Subject: RE: [PATCH] Refactor lit.cfg to use lit.util.which
> >
> > Ping*2. +Daniel Dunbar as LIT owner, hope that's okay.
> >
> > I want to use this as the basis for adding equivalent code
> > to Clang's lit.cfg which currently doesn't do the tool name
> > substitution thing.  We really need that for our builds.
> > Thanks,
> > --paulr
> >
> > > -----Original Message-----
> > > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > > bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> > > Sent: Friday, March 07, 2014 9:45 AM
> > > To: llvm-commits at cs.uiuc.edu commits (llvm-commits at cs.uiuc.edu)
> > > Subject: RE: [PATCH] Refactor lit.cfg to use lit.util.which
> > >
> > > Ping. LIT owner? not sure who.
> > > --paulr
> > >
> > > > -----Original Message-----
> > > > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > > > bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> > > > Sent: Tuesday, March 04, 2014 5:01 PM
> > > > To: llvm-commits at cs.uiuc.edu commits (llvm-commits at cs.uiuc.edu)
> > > > Subject: [PATCH] Refactor lit.cfg to use lit.util.which
> > > >
> > > > llvm/test/lit.cfg was doing tool-name substitutions using PATHEXT
> > > > and os.path.exists().  Better to use lit.util.which, as a
> > centralized
> > > > place that knows path-name quirks.
> > > > As a side effect, it's easy to tell if a tool doesn't exist, so I
> > > > removed some non-existent tools from the list.  (Possibly 'clang'
> > > > should also be removed? It shouldn't be used for any LLVM tests...)
> > > >
> > > > Okay to submit?
> > > > Thanks,
> > > > --paulr
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140320/28ccd237/attachment.html>


More information about the llvm-commits mailing list