[compiler-rt] r203572 - [ASan] Don't build the ASan runtime with -undefined dynamic_lookup, which isn't necessary anymore.

[Alexey Samsonov]

On Tue, Mar 11, 2014 at 6:04 PM, Alexander Potapenko <glider at google.com>wrote:

> Author: glider
> Date: Tue Mar 11 09:04:09 2014
> New Revision: 203572
>
> URL: http://llvm.org/viewvc/llvm-project?rev=203572&view=rev
> Log:
> [ASan] Don't build the ASan runtime with -undefined dynamic_lookup, which
> isn't necessary anymore.
> Fixes https://code.google.com/p/address-sanitizer/issues/detail?id=266.
>
> Modified:
>     compiler-rt/trunk/lib/asan/CMakeLists.txt
>
> Modified: compiler-rt/trunk/lib/asan/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/CMakeLists.txt?rev=203572&r1=203571&r2=203572&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/lib/asan/CMakeLists.txt (original)
> +++ compiler-rt/trunk/lib/asan/CMakeLists.txt Tue Mar 11 09:04:09 2014
> @@ -78,10 +78,6 @@ endif()
>  add_custom_target(asan)
>  if(APPLE)
>    foreach (os ${SANITIZER_COMMON_SUPPORTED_DARWIN_OS})
> -    # Dynamic lookup is needed because shadow scale and offset are
> -    # provided by the instrumented modules.
> -    set(ASAN_RUNTIME_LDFLAGS
> -        "-undefined dynamic_lookup")
>      add_compiler_rt_darwin_dynamic_runtime(clang_rt.asan_${os}_dynamic
> ${os}
>        ARCH ${ASAN_SUPPORTED_ARCH}
>        SOURCES $<TARGET_OBJECTS:RTAsan.${os}>
>

Do you need to delete ASAN_RUNTIME_LDFLAGS
from add_compiler_rt_darwin_dynamic_runtime invocation as well?


>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140311/48f3f741/attachment.html>