<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 11, 2014 at 6:04 PM, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: glider<br>
Date: Tue Mar 11 09:04:09 2014<br>
New Revision: 203572<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=203572&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=203572&view=rev</a><br>
Log:<br>
[ASan] Don't build the ASan runtime with -undefined dynamic_lookup, which isn't necessary anymore.<br>
Fixes <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=266" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=266</a>.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/asan/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/lib/asan/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/CMakeLists.txt?rev=203572&r1=203571&r2=203572&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/CMakeLists.txt?rev=203572&r1=203571&r2=203572&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/asan/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/lib/asan/CMakeLists.txt Tue Mar 11 09:04:09 2014<br>
@@ -78,10 +78,6 @@ endif()<br>
 add_custom_target(asan)<br>
 if(APPLE)<br>
   foreach (os ${SANITIZER_COMMON_SUPPORTED_DARWIN_OS})<br>
-    # Dynamic lookup is needed because shadow scale and offset are<br>
-    # provided by the instrumented modules.<br>
-    set(ASAN_RUNTIME_LDFLAGS<br>
-        "-undefined dynamic_lookup")<br>
     add_compiler_rt_darwin_dynamic_runtime(clang_rt.asan_${os}_dynamic ${os}<br>
       ARCH ${ASAN_SUPPORTED_ARCH}<br>
       SOURCES $<TARGET_OBJECTS:RTAsan.${os}><br></blockquote><div><br></div><div>Do you need to delete ASAN_RUNTIME_LDFLAGS from add_compiler_rt_darwin_dynamic_runtime invocation as well?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>