[PATCH] Remove out of date wording from LangRef
chisophugis at gmail.com
Tue Mar 4 15:30:51 PST 2014
On Tue, Mar 4, 2014 at 12:51 PM, Philip Reames <listmail at philipreames.com>wrote:
> +Chris under the hope he can clarify
> On 03/01/2014 04:01 PM, Sean Silva wrote:
> Patch Comment:
>> This patch removes confusing and out of date text from the LangRef. LLVM
>> no longer performs structural uniquing on named types. Most of the
>> documentation was updated to reflect this, but this section got missed. I
>> attempted to replace the original wording with appropriate forward
>> references, but it's debatable whether the section should be kept at all.
> I think you have the direction of this patch backward. AFAIK the
> *current* system uses structural uniquing.
> -- Sean Silva
> This is *exactly* the point I was trying to get clarify on in my
> original email to llvmdev.
> I believe that your interpretation is incorrect. I'm going off this blog
Your reading seems correct. I guess it doesn't surprise me that I was
wrong; I have really done very little IR-level work that creates types...
> Chris - Could you clarify? Does the current type system combine
> structural types with different names?
I think you were right. My bad. The second thing I was going to ask for
though is a second opinion of an IR guru to doublecheck this, so Chris was
probably going to end up in this thread anyway ;)
-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits