<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 4, 2014 at 12:51 PM, Philip Reames <span dir="ltr"><<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
+Chris under the hope he can clarify<div class=""><br>
<br>
<div>On 03/01/2014 04:01 PM, Sean Silva
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Patch Comment:<br>
This patch removes confusing and out of date text from the
LangRef. LLVM no longer performs structural uniquing on
named types. Most of the documentation was updated to
reflect this, but this section got missed. I attempted to
replace the original wording with appropriate forward
references, but it's debatable whether the section should
be kept at all.</blockquote>
<div><br>
</div>
<div>I think you have the direction of this patch backward.
AFAIK the *current* system uses structural uniquing.</div>
<div><br>
</div>
<div>-- Sean Silva</div>
<br>
</div>
</div>
</div>
</blockquote></div>
This is *exactly* the point I was trying to get clarify on in my
original email to llvmdev. <br>
<br>
I believe that your interpretation is incorrect. I'm going off this
blog post:<br>
<a href="http://blog.llvm.org/2011/11/llvm-30-type-system-rewrite.html" target="_blank">http://blog.llvm.org/2011/11/llvm-30-type-system-rewrite.html</a></div></blockquote><div><br></div><div>Your reading seems correct. I guess it doesn't surprise me that I was wrong; I have really done very little IR-level work that creates types...</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><br>
<br>
Chris - Could you clarify? Does the current type system combine
structural types with different names?<br></div></blockquote><div><br></div><div>I think you were right. My bad. The second thing I was going to ask for though is a second opinion of an IR guru to doublecheck this, so Chris was probably going to end up in this thread anyway ;)</div>
<div><br></div><div>-- Sean Silva</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
<br>
Yours,<br>
Philip<br>
</div>
</blockquote></div><br></div></div>