[patch] implement __clear_cache for arm32 & mips

JF Bastien jfb at google.com
Tue Mar 4 15:13:19 PST 2014


(I'm unfamiliar with MIPS, simply reviewing the ARM code)

* It would be better to put the ARM code with the NetBSD ARM code, not
separate.
* Some platforms apparently fail doing this properly, and syscall returns
an error. I don't know if Android guarantees that this works, but it may be
worth checking the return value and aborting on syscall failure.
* JITs I've seen all use inline asm with a straight call to svc (with
proper ARM/Thumb headache). There seems to be mysticism around this that
I've never quite grasped, since the compiler should just emit the svc. See:
http://v8.googlecode.com/svn/branches/bleeding_edge/src/arm/cpu-arm.cc



On Wed, Feb 26, 2014 at 8:36 AM, Narayan Kamath <narayan at google.com> wrote:

> Note that both arm32 and mips flavours of this code generate
> a syscall.
>
>
> _________________
> Save Rainforests
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140304/999adc11/attachment.html>


More information about the llvm-commits mailing list