[PATCH][DAGCombiner] Factor out new function distributeTruncateThroughAnd
echristo at gmail.com
Mon Mar 3 15:38:50 PST 2014
Go ahead and comment the hasOneUse bit but otherwise it seems fairly obvious.
On Mon, Mar 3, 2014 at 3:14 PM, Adam Nemet <anemet at apple.com> wrote:
> Sure thing, thanks for looking at the patch. I only pulled out the AND in order to hide as much detail as possible. Hopefully all this will get inlined.
> New version attached.
> On Mar 3, 2014, at 2:23 PM, Eric Christopher <echristo at gmail.com> wrote:
>> In the current incarnation it looks like you could hoist the check for
>> AND and hasOneUse up out of the function? (Or at least the AND since
>> it's part of the function name).
>> On Mon, Mar 3, 2014 at 2:17 PM, Adam Nemet <anemet at apple.com> wrote:
>>> Currently this code is duplicated across visitSHL, visitSRA and visitSRL. The
>>> plan is to also add rotates as clients to this new function.
>>> There is no functional change intended here.
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
More information about the llvm-commits