[PATCH][DAGCombiner] Factor out new function distributeTruncateThroughAnd

Adam Nemet anemet at apple.com
Mon Mar 3 15:14:26 PST 2014

Sure thing, thanks for looking at the patch.  I only pulled out the AND in order to hide as much detail as possible.  Hopefully all this will get inlined.

New version attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-DAGCombiner-Factor-out-distributeTruncateThroughAnd.patch
Type: application/octet-stream
Size: 5810 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140303/5c6efd4e/attachment.obj>
-------------- next part --------------

On Mar 3, 2014, at 2:23 PM, Eric Christopher <echristo at gmail.com> wrote:

> In the current incarnation it looks like you could hoist the check for
> AND and hasOneUse up out of the function? (Or at least the AND since
> it's part of the function name).
> -eric
> On Mon, Mar 3, 2014 at 2:17 PM, Adam Nemet <anemet at apple.com> wrote:
>> Currently this code is duplicated across visitSHL, visitSRA and visitSRL.  The
>> plan is to also add rotates as clients to this new function.
>> There is no functional change intended here.
>> Adam
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list