[patch] Always open files in binary mode

Aaron Ballman aaron at aaronballman.com
Mon Feb 24 06:37:06 PST 2014


On Mon, Feb 24, 2014 at 9:35 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> Let me ask this: what's the harm in allowing text output as we've been doing?
>
> The harm is in the default. It is really easy to forget to pass the
> F_Binary flag and then get broken tests on windows. If everything just
> worked with binary, that would have been the easy solution. Since it
> doesn't, I am currently working on a patch to switch us to having a
> F_Text flag instead.

I think that sounds like a great solution! Thanks for working on this!

~Aaron




More information about the llvm-commits mailing list