[patch] Always open files in binary mode

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Feb 24 06:35:10 PST 2014


> Let me ask this: what's the harm in allowing text output as we've been doing?

The harm is in the default. It is really easy to forget to pass the
F_Binary flag and then get broken tests on windows. If everything just
worked with binary, that would have been the easy solution. Since it
doesn't, I am currently working on a patch to switch us to having a
F_Text flag instead.

> ~Aaron

Thanks,
Rafael



More information about the llvm-commits mailing list