[PATCH] Move CodeGenPrepare into lib/CodeGen

Quentin Colombet qcolombet at apple.com
Wed Feb 19 17:42:10 PST 2014


Hi,

This patch moves CodeGenPrepare into lib/CodeGen.
This is a follow-up of the RFC: http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-February/070463.html

** Context **

To sum-up CodeGenPrepare relies on the functionalities implemented in TargetLowering.
TargetLowering is part of the library CodeGen, whereas CodeGenPrepare is part of the library ScalarOpts.

This is a layer violation which would introduce eventually a dependence on CodeGen in ScalarOpts.


** Proposed Solution **

Following the feedback of the RFC, CodeGenPrepare is moved into lib/CodeGen.

As one can notice (makefile, CMakeLists) the patch introduces a dependency on libLLVMCodeGen for both opt and bugpoint because of that.

The dependency for bugpoint could be avoid if we were less aggressive in LinkAllPasses.h.


Thanks for your review,
-Quentin

PS: svn move produced a weird diff with CodeGenPrepare.cpp. The file is indeed moved into lib/CodeGen then the small modification on the included files is applied.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140219/e7a46a8b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-codegen.patch
Type: application/octet-stream
Size: 119237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140219/e7a46a8b/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140219/e7a46a8b/attachment-0001.html>


More information about the llvm-commits mailing list