<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi,<div><br></div><div>This patch moves CodeGenPrepare into lib/CodeGen.</div><div>This is a follow-up of the RFC: <a href="http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-February/070463.html">http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-February/070463.html</a></div><div><br></div><div>** Context **</div><div><br></div><div>To sum-up CodeGenPrepare relies on the functionalities implemented in TargetLowering.</div><div>TargetLowering is part of the library CodeGen, whereas CodeGenPrepare is part of the library ScalarOpts.</div><div><br></div><div>This is a layer violation which would introduce eventually a dependence on CodeGen in ScalarOpts.</div><div><br></div><div><br></div><div>** Proposed Solution **</div><div><br></div><div>Following the feedback of the RFC, CodeGenPrepare is moved into lib/CodeGen.</div><div><br></div><div>As one can notice (makefile, CMakeLists) the patch introduces a dependency on libLLVMCodeGen for both opt and bugpoint because of that.</div><div><br></div><div>The dependency for bugpoint could be avoid if we were less aggressive in LinkAllPasses.h.</div><div><br></div><div><br></div><div>Thanks for your review,</div><div><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">PS: svn move produced a weird diff with CodeGenPrepare.cpp. The file is indeed moved into lib/CodeGen then the small modification on the included files is applied.</div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "></div></div></div></body></html>