[llvm] r200962 - [Sparc] Emit relocations for Thread Local Storage (TLS) when integrated assembler is used.

Venkatraman Govindaraju venkatra at cs.wisc.edu
Tue Feb 18 12:06:19 PST 2014


On Mon, Feb 10, 2014 at 8:54 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> +; RUN: llc <%s -march=sparc   -relocation-model=static -filetype=obj | llvm-readobj -r | FileCheck %s --check-prefix=v8abs-obj
>> +; RUN: llc <%s -march=sparcv9 -relocation-model=static -filetype=obj | llvm-readobj -r | FileCheck %s --check-prefix=v9abs-obj
>> +; RUN: llc <%s -march=sparc   -relocation-model=pic    -filetype=obj | llvm-readobj -r | FileCheck %s --check-prefix=pic-obj
>> +; RUN: llc <%s -march=sparcv9 -relocation-model=pic    -filetype=obj | llvm-readobj -r | FileCheck %s --check-prefix=pic-obj
>
> Please never tests using "llc -filetype=obj". You should be able to
> test this with llvm-mc.

Thank you for the review.
I used 'llc' to test the relocations emitted by MC layer, because
SparcAsmParser is a WIP and it is not mature enough to emit PIC
relocations correctly. Once it can, we may revisit and use llvm-mc to
test.

Out of curiosity, why should we not use 'llc -filetype=obj' to test?

Thanks,
Venkat

>
> Cheers,
> Rafael




More information about the llvm-commits mailing list