[llvm] r200962 - [Sparc] Emit relocations for Thread Local Storage (TLS) when integrated assembler is used.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Feb 18 12:15:27 PST 2014


> Thank you for the review.
> I used 'llc' to test the relocations emitted by MC layer, because
> SparcAsmParser is a WIP and it is not mature enough to emit PIC
> relocations correctly. Once it can, we may revisit and use llvm-mc to
> test.
>
> Out of curiosity, why should we not use 'llc -filetype=obj' to test?

One reason is that it is extremely brittle. A change in codegen can
change what the MC layer is seeing. That can break the test or change
it so that it is not longer testing what it was designed to test.

Another issue is that it opens the possibility that we can output an
object file that doesn't correspond to any .s. That makes debugging
harder since everything looks fine when reading the .s.

Cheers,
Rafael



More information about the llvm-commits mailing list