[PATCH] Generate DWARF stack frame information for ARM/Thumb functions [2nd attempt].

Keith Walker kwalker at arm.com
Thu Feb 6 04:14:03 PST 2014


At the moment this patch is generating the DWARF in a similar way to what is done on the other targets by using the logic in the *FrameLowering:emitPrologue() to generated the DWARF stack directives.

The EHABI directives on the other hand are generated by analysing the restricted set of instructions generated in the prologue.

It would make sense to do a subsequent refactoring to make them use the same logic.

Keith

> -----Original Message-----
> From: Renato Golin [mailto:renato.golin at linaro.org]
> Sent: 06 February 2014 11:09
> To: Keith Walker
> Cc: llvm-commits at cs.uiuc.edu; Amara Emerson
> Subject: Re: [PATCH] Generate DWARF stack frame information for
> ARM/Thumb functions [2nd attempt].
> 
> 
>   Hi Keith,
> 
>   I'll let others (Eric?) review the Dwarf logic, but regarding the
> ARMException issue, I think for this patch, we should do it this way.
> It'd be better if the unwinding logic got factored out on its own
> class, so both Dwarf and exception handling producers could use, but
> this is not the purpose of this patch, and honestly, your patch changes
> nothing in that area. If anything, it makes more clear what the
> similarities are, and it'll make it easier to re-factor the code later.
> 
>   Also, thanks for the huge amount of tests, it's really appreciated!
> 
>   cheers,
>   --renato
> 
> http://llvm-reviews.chandlerc.com/D2706







More information about the llvm-commits mailing list