[PATCH] Generate DWARF stack frame information for ARM/Thumb functions [2nd attempt].

Renato Golin renato.golin at linaro.org
Thu Feb 6 03:08:37 PST 2014


  Hi Keith,

  I'll let others (Eric?) review the Dwarf logic, but regarding the ARMException issue, I think for this patch, we should do it this way. It'd be better if the unwinding logic got factored out on its own class, so both Dwarf and exception handling producers could use, but this is not the purpose of this patch, and honestly, your patch changes nothing in that area. If anything, it makes more clear what the similarities are, and it'll make it easier to re-factor the code later.

  Also, thanks for the huge amount of tests, it's really appreciated!

  cheers,
  --renato

http://llvm-reviews.chandlerc.com/D2706



More information about the llvm-commits mailing list