[llvm] r199287 - Only mark functions as micromips.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jan 16 08:13:18 PST 2014


> We've had a big discussion off-list about that. By the end of it, everyone was in complete agreement with your side of the argument so I'm hopeful that you won't encounter resistance to this again. Thanks for bearing with us.

Awesome.

>> Before r199181 (and before r192035) they were just marking functions in
>> MipsAsmPrinter::EmitFunctionEntryLabel, so I am pretty sure the current
>> state handles as many cases as before, but using the correct MC interface.
>
> I believe Zoran has a patch under review to handle the basic block labels ([PATCH] Set basic block start as microMIPS).

Yes, but that patch was using emitMipsHackSTOCG. As the name imply,
that was really just a hack to get the Mips backend to use a single
code path through MC. That is what got me to go read the gas manual
and find out what the actual interface should be (.set micromips/.set
nomicromips).

Cheers,
Rafael



More information about the llvm-commits mailing list