[llvm] r199287 - Only mark functions as micromips.

[Daniel Sanders]

Hi Rafael,

> I implemented ".set micromips" out of despair of repeatedly insisting that
> mips should implement their MC layer and having they trying over and over
> to "just use llc -filetype=obj".

We've had a big discussion off-list about that. By the end of it, everyone was in complete agreement with your side of the argument so I'm hopeful that you won't encounter resistance to this again. Thanks for bearing with us.

> Before r199181 (and before r192035) they were just marking functions in
> MipsAsmPrinter::EmitFunctionEntryLabel, so I am pretty sure the current
> state handles as many cases as before, but using the correct MC interface.

I believe Zoran has a patch under review to handle the basic block labels ([PATCH] Set basic block start as microMIPS). 

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Rafael Espíndola
> Sent: 15 January 2014 15:22
> To: Rafael Espindola; llvm-commits; Richard Sandiford
> Subject: Re: [llvm] r199287 - Only mark functions as micromips.
> 
> > I strongly suggest not doing something different for LLVM.  This stuff
> > is hairy enough as it is without having two different interpretations
> > of the same assembly.
> 
> Thank you so much for the explanation! Given it I agree that MC should
> implement the same rules as gas. I reported pr18487 with the information
> you provided.
> 
> I implemented ".set micromips" out of despair of repeatedly insisting that
> mips should implement their MC layer and having they trying over and over
> to "just use llc -filetype=obj". Having said that, my only interest in mips is
> keeping MC sane. Before r199181 (and before
> r192035) they were just marking functions in
> MipsAsmPrinter::EmitFunctionEntryLabel, so I am pretty sure the current
> state handles as many cases as before, but using the correct MC interface.
> 
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits