[LNT] r198453 - In an effort refactor the code to make way for run resampling, move the run submission code into the test suites.

[Tobias Grosser]

On 01/04/2014 11:53 PM, Chris Matthews wrote:
> The commit where I introduced sub-command output printing in verbose mode was back in November:
>
> http://llvm.org/viewvc/llvm-project?view=revision&revision=195509
>
> Though at the time you would not have seen that without passing two verbose flags to the LNT invocation.

Interesting. The extremely verbose output was only visible since 
yesterday (probably due to your changes).

I agree that it may make sense to have a verbose output for a console 
run that prints the subcommand output. Also I can see that we may want 
to unify the flags. For the buildbot I am OK disabling the verbose mode, 
as long as the basic information of which iteration is currently 
executed is still available (I am not sure if this is currently the 
case). If we decide to change buildbot flags, it would be great to first 
update the configurate and restart the buildmaster before reapplying the 
verbose changes.

> So, what I will do is reapply some of those patches from yesterday, *very* carefully, making sure everything is working.  I will revert r195509 while we discuss whether we should not use —verbose on the bots, or not do subcommand printing in verbose at all.   If there are spare slaves I will have the regenerate the data from yesterday’s failed runs.
 >
>
> Objections?

Rather a question. How will you make sure everything is working? Did you 
actually test them offline? As LNT breaks have a rather long delay and 
many people will be notified, I think it is very important to avoid
breaking the builds.

Also, did you investigate the causes of why some of the buildbots broke 
(the commit message of your resubmitted patch does not say anything 
about this)?

Traceback (most recent call last):
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", 
line 287, in addCallbacks
     self._runCallbacks()
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", 
line 545, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", 
line 362, in callback
     self._startRunCallbacks(result)
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", 
line 458, in _startRunCallbacks
     self._runCallbacks()
--- <exception caught here> ---
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", 
line 545, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", 
line 807, in _gotResults
     self.setStatus(cmd, results)
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", 
line 895, in setStatus
     self.step_status.setText(self.getText(cmd, results))
   File 
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", 
line 872, in getText
     return self.describe(True) + ["failed"]
   File "/Volumes/Macintosh 
HD2/llvm.buildmaster/zorg/zorg/buildbot/commands/LitTestCommand.py", 
line 143, in describe
     description.append('{0} {1}'.format(count, self.resultNames[name]))
exceptions.KeyError: 'clang'


Thanks again for your work on LNT. Your changes look in fact very 
interesting!

Tobias