[LNT] r198453 - In an effort refactor the code to make way for run resampling, move the run submission code into the test suites.

[Chris Matthews]

The commit where I introduced sub-command output printing in verbose mode was back in November:

http://llvm.org/viewvc/llvm-project?view=revision&revision=195509

Though at the time you would not have seen that without passing two verbose flags to the LNT invocation.

So, what I will do is reapply some of those patches from yesterday, *very* carefully, making sure everything is working.  I will revert r195509 while we discuss whether we should not use —verbose on the bots, or not do subcommand printing in verbose at all.   If there are spare slaves I will have the regenerate the data from yesterday’s failed runs.

Objections?

On Jan 4, 2014, at 1:38 PM, Chris Matthews <chris.matthews at apple.com> wrote:

> Thanks for reverting Tobias! I did not think these changes would impact much.  I will investigate right now.
> 
> I think the problem with stdout is that I merged the lnt verbose flag and the nt verbose flag, so now any verbose flag turns verbose on everywhere during the run.  This was to avoid invocations like "lnt --verbose nt --verbose”, because the first -v didn’t really do anything and you might not even know you need the second —verbose. 
> 
> Whether —verbose prints the output of subcommands is a good question.  I can see why you don’t want that on the buildbot, it does obscure the log and duplicate the data.  It is more useful on command line runs where the logs are not as easy to reach.
> 
> I will verify my hypothesis about the flags, and disable make the stdout quiet again.
> 
> On Jan 4, 2014, at 7:16 AM, Tobias Grosser <tobias at grosser.es> wrote:
> 
>> On 01/04/2014 03:53 PM, Tobias Grosser wrote:
>>> On 01/03/2014 11:50 PM, Chris Matthews wrote:
>>>> Author: cmatthews
>>>> Date: Fri Jan  3 16:50:32 2014
>>>> New Revision: 198453
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=198453&view=rev
>>>> Log:
>>>> In an effort refactor the code to make way for run resampling, move
>>>> the run submission code into the test suites.
>>>> 
>>>> With resampling the submission logic will change in NT.
>>>> Deprecate runtest command line args. Move submit code into common
>>>> subclass. Refactored out the result printing code, as it was common to
>>>> several places.
>>> 
>>> Hi Chris,
>>> 
>>> this change made the stdio of LNT a lot more verbose:
>>> 
>>> compare:
>>> 
>>> http://lab.llvm.org:8011/builders/polly-perf-O3/builds/435/steps/lnt.nightly-test/logs/stdio
>>> 
>>> 
>>> to
>>> 
>>> http://lab.llvm.org:8011/builders/polly-perf-O3/builds/436/steps/lnt.nightly-test/logs/stdio
>>> 
>>> 
>>> We now print information that is already logged in configure.log and
>>> test.log. So there does not see any reason to also dump this to stdio.
>>> Also, it makes it very hard to get a high level idea of the test progress.
>>> 
>>> Could you fix this quickly or revert it, in case we need to discuss this
>>> further.
>> 
>> Hi Chris,
>> 
>> I just figured that the commit broke in fact all LNT buildbots. Also, my previous fix was not enough to get them back.
>> 
>> I reverted your commit for now in r198496.
>> 
>> Maybe you could have a look into what needs to be changed to avoid such breakages.
>> 
>> Cheers,
>> Tobias
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140104/a9078f32/attachment.html>