[llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of

[Eric Christopher]

Awesome. Makes total sense :)

Thanks Daniel.

-eric

On Thu Dec 19 2013 at 3:22:57 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

>  Hi Eric,
>
>
>
> For the sake of completeness I should mention that a few reviews have been
> taking place in the MIPS BugZilla (because not everyone has a phabricator
> account yet). The MIPS BugZilla is publicly visible but it's not an
> appropriate place to keep the post-commit reviews from LLVM's point of
> view. For now, I've been copying these reviews into phabricator when they
> raise an issue.
>
>
>
> If a review ever turns up a bigger issue than style or whitespace, then I
> intend to make sure a corresponding reply to the commit-email is sent since
> email is still the primary system.
>
>
>
> *From:* llvm-commits-bounces at cs.uiuc.edu [mailto:
> llvm-commits-bounces at cs.uiuc.edu] *On Behalf Of *Eric Christopher
> *Sent:* 19 December 2013 02:20
> *To:* Reed Kotler; llvm-commits at cs.uiuc.edu
> *Subject:* RE: [llvm] r197638 - Make cosmetic changes as part of Mips
> internal post commit review of
>
>
>
>
>
> On Wed Dec 18 2013 at 4:57:26 PM, Reed Kotler <Reed.Kotler at imgtec.com>
> wrote:
>
>  You have to discuss this with Daniel Sanders who is the Mips maintainer
> and requestor of post commit
>
> reviews.
>
>
>
>
>
> Not really. I'm discussing it with the person making the commits.
>
>
>
>   We are using phabricator for the post commit review and there is a bug
> filed in our local
>
> bugzilla.
>
>
>
>
>
> Ah, that makes sense. From your commit comment you made it sound like he'd
> sent you a private mail about it.
>
>
>
> -eric
>
>
>
>   Perhaps the work flow should be different. It does not matter much to
> me.
>
>
>
> Reed
>
>
>   ------------------------------
>
> *From:* Eric Christopher [echristo at gmail.com]
> *Sent:* Wednesday, December 18, 2013 4:50 PM
> *To:* Reed Kotler; llvm-commits at cs.uiuc.edu
> *Subject:* [llvm] r197638 - Make cosmetic changes as part of Mips
> internal post commit review of
>
> Why not just have everyone reply to your original commit?
>
>
>
> -eric
>
> On Wed Dec 18 2013 at 4:49:16 PM, Reed Kotler <rkotler at mips.com> wrote:
>
> Author: rkotler
> Date: Wed Dec 18 18:43:08 2013
> New Revision: 197638
>
> URL: http://llvm.org/viewvc/llvm-project?rev=197638&view=rev
> Log:
> Make cosmetic changes as part of Mips internal post commit review of
> patch r196331.
>
>
> Modified:
>     llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp
>
> Modified: llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp Wed Dec 18
> 18:43:08 2013
> @@ -1625,7 +1625,7 @@ MipsConstantIslands::fixupConditionalBr(
>    MachineBasicBlock *MBB = MI->getParent();
>    MachineInstr *BMI = &MBB->back();
>    bool NeedSplit = (BMI != MI) || !BBHasFallthrough(MBB);
> -  unsigned OppositeBranchOpcode=TII->getOppositeBranchOpc(Opcode);
> +  unsigned OppositeBranchOpcode = TII->getOppositeBranchOpc(Opcode);
>
>    ++NumCBrFixed;
>    if (BMI != MI) {
> @@ -1674,9 +1674,9 @@ MipsConstantIslands::fixupConditionalBr(
>      BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))
>             .addReg(MI->getOperand(0).getReg())
>             .addMBB(NextBB);
> -  }
> -  else { BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))
> -        .addMBB(NextBB);
> +  } else {
> +    BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))
> +           .addMBB(NextBB);
>    }
>    Br.MI = &MBB->back();
>    BBInfo[MBB->getNumber()].Size += TII->GetInstSizeInBytes(&MBB->back());
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>           English »
>
> AfrikaansAlbanianArabic ArmenianAzerbaijaniBasque BengaliBelarusian
> BulgarianCatalanChinese (Simp) Chinese (Trad)Croatian CzechDanish
> DutchEnglishEsperanto EstonianFilipinoFinnish FrenchGalicianGeorgian
> GermanGreekGujarati Haitian CreoleHebrewHindi HungarianIcelandic
> IndonesianIrishItalian JapaneseKannadaKorean LaoLatinLatvian
> LithuanianMacedonianMalay MalteseNorwegian PersianPolishPortuguese
> RomanianRussianSerbian SlovakSlovenian SpanishSwahiliSwedish
> TamilTeluguThai TurkishUkrainianUrdu VietnameseWelshYiddish
>
>
>
> Feedback : History : Options
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131219/056599f0/attachment.html>