Awesome. Makes total sense :)<div><br></div><div>Thanks Daniel.</div><div><br></div><div>-eric<br><br><div>On Thu Dec 19 2013 at 3:22:57 AM, Daniel Sanders <<a href="mailto:Daniel.Sanders@imgtec.com">Daniel.Sanders@imgtec.com</a>> wrote:</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="purple">
<div>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hi Eric,<u></u><u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">For the sake of completeness I should mention that a few reviews have been taking place in the MIPS BugZilla (because not everyone has a phabricator account yet). The MIPS
BugZilla is publicly visible but it's not an appropriate place to keep the post-commit reviews from LLVM's point of view. For now, I've been copying these reviews into phabricator when they raise an issue.<u></u><u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">If a review ever turns up a bigger issue than style or whitespace, then I intend to make sure a corresponding reply to the commit-email is sent since email is still the primary
system.<u></u><u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> <a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>Eric Christopher<br>
<b>Sent:</b> 19 December 2013 02:20<br>
<b>To:</b> Reed Kotler; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> RE: [llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-GB" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<p><u></u> <u></u></p>
<p style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p>On Wed Dec 18 2013 at 4:57:26 PM, Reed Kotler <<a href="mailto:Reed.Kotler@imgtec.com" target="_blank">Reed.Kotler@imgtec.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">You have to discuss this with Daniel Sanders who is the Mips maintainer and requestor of post commit
<u></u><u></u></span></p>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">reviews.
<u></u><u></u></span></p>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><u></u> <u></u></span></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p><u></u> <u></u></p>
</div>
<div>
<p>Not really. I'm discussing it with the person making the commits.<u></u><u></u></p>
</div>
<div>
<p> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">We are using phabricator for the post commit review and there is a bug filed in our local<u></u><u></u></span></p>
</div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">bugzilla.<u></u><u></u></span></p>
</div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><u></u> <u></u></span></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p><u></u> <u></u></p>
</div>
<div>
<p>Ah, that makes sense. From your commit comment you made it sound like he'd sent you a private mail about it.<u></u><u></u></p>
</div>
<div>
<p><u></u> <u></u></p>
</div>
<div>
<p>-eric<u></u><u></u></p>
</div>
<div>
<p> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">Perhaps the work flow should be different. It does not matter much to me.<u></u><u></u></span></p>
</div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><u></u> <u></u></span></p>
</div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">Reed<u></u><u></u></span></p>
</div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><u></u> <u></u></span></p>
</div>
<div>
<div>
<div align="center" style="text-align:center"><span style="color:black">
<hr size="2" width="100%" align="center">
</span></div>
<div>
<p style="margin-bottom:12.0pt"><b><span style="font-family:"Tahoma","sans-serif";color:black">From:</span></b><span style="font-family:"Tahoma","sans-serif";color:black"> Eric Christopher [<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]<br>
<b>Sent:</b> Wednesday, December 18, 2013 4:50 PM<br>
<b>To:</b> Reed Kotler; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">
llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of</span><span style="color:black"><u></u><u></u></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<div>
<div>
<div>
<p><span style="color:black">Why not just have everyone reply to your original commit?
<u></u><u></u></span></p>
<div>
<p><span style="color:black"><u></u> <u></u></span></p>
</div>
<div>
<p style="margin-bottom:12.0pt"><span style="color:black">-eric<u></u><u></u></span></p>
<div>
<p><span style="color:black">On Wed Dec 18 2013 at 4:49:16 PM, Reed Kotler <<a href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>> wrote:<u></u><u></u></span></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p><span style="color:black">Author: rkotler<br>
Date: Wed Dec 18 18:43:08 2013<br>
New Revision: 197638<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197638&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=197638&view=rev</a><br>
Log:<br>
Make cosmetic changes as part of Mips internal post commit review of<br>
patch r196331.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp Wed Dec 18 18:43:08 2013<br>
@@ -1625,7 +1625,7 @@ MipsConstantIslands::fixupConditionalBr(<br>
MachineBasicBlock *MBB = MI->getParent();<br>
MachineInstr *BMI = &MBB->back();<br>
bool NeedSplit = (BMI != MI) || !BBHasFallthrough(MBB);<br>
- unsigned OppositeBranchOpcode=TII->getOppositeBranchOpc(Opcode);<br>
+ unsigned OppositeBranchOpcode = TII->getOppositeBranchOpc(Opcode);<br>
<br>
++NumCBrFixed;<br>
if (BMI != MI) {<br>
@@ -1674,9 +1674,9 @@ MipsConstantIslands::fixupConditionalBr(<br>
BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))<br>
.addReg(MI->getOperand(0).getReg())<br>
.addMBB(NextBB);<br>
- }<br>
- else { BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))<br>
- .addMBB(NextBB);<br>
+ } else {<br>
+ BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))<br>
+ .addMBB(NextBB);<br>
}<br>
Br.MI = &MBB->back();<br>
BBInfo[MBB->getNumber()].Size += TII->GetInstSizeInBytes(&MBB->back());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></span></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<table border="0" cellspacing="1" cellpadding="0">
<tbody>
<tr>
<td width="20%" style="width:20.0%;padding:.75pt .75pt .75pt .75pt">
<div>
<p>English »<u></u><u></u></p>
</div>
</td>
<td width="20%" style="width:20.0%;padding:.75pt .75pt .75pt .75pt">
<p>AfrikaansAlbanianArabic ArmenianAzerbaijaniBasque BengaliBelarusian BulgarianCatalanChinese (Simp) Chinese (Trad)Croatian CzechDanish DutchEnglishEsperanto EstonianFilipinoFinnish FrenchGalicianGeorgian GermanGreekGujarati Haitian CreoleHebrewHindi
HungarianIcelandic IndonesianIrishItalian JapaneseKannadaKorean LaoLatinLatvian LithuanianMacedonianMalay MalteseNorwegian PersianPolishPortuguese RomanianRussianSerbian SlovakSlovenian SpanishSwahiliSwedish TamilTeluguThai TurkishUkrainianUrdu VietnameseWelshYiddish<u></u><u></u></p>
</td>
<td width="13%" style="width:13.0%;padding:.75pt .75pt .75pt .75pt">
<p align="center" style="text-align:center"> <u></u><u></u></p>
</td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="5%" style="width:5.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
</div>
</div>
<div>
<p><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">Feedback : History : Options<u></u><u></u></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div></div></div></blockquote></div>