Fwd: [PATCH] Zorg, lld build factory: Remove -stdlib=libc++ as this breaks the GNU build

Mikael Lyngvig mikael at lyngvig.org
Tue Dec 17 09:21:39 PST 2013


Please?  Is there anybody out there?  I've tried to get this 15 character
patch commited for for a week now.  My builder has now failed some 225
builds because nobody has bothered to commit the patch.

Rui has said "LGTM" about it.  Chandler has suggested a change to the
initial patch which has been implemented in this patch.

Now I know what I want for Christmas this year!  A 15-character patch of
Zorg...


-- Mikael

---------- Forwarded message ----------
From: Mikael Lyngvig <mikael at lyngvig.org>
Date: 2013/12/12
Subject: [PATCH] Zorg, lld build factory: Remove -stdlib=libc++ as this
breaks the GNU build
To: LLVM-commits <llvm-commits at cs.uiuc.edu>


Anyone?  My builder keeps failing until this patch is committed.

Index: zorg/buildbot/builders/LLDBuilder.py
===================================================================
--- zorg/buildbot/builders/LLDBuilder.py (revision 196862)
+++ zorg/buildbot/builders/LLDBuilder.py (working copy)
@@ -57,10 +57,11 @@
                                haltOnFailure=False,
                                description=["create build dir"],
                                workdir="."))
+
     cmakeCommand = [
         "cmake",
         "-DCMAKE_BUILD_TYPE=Release",
-        "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -stdlib=libc++
-U__STRICT_ANSI__\"",
+        "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -U__STRICT_ANSI__\"",
         "../%s" % llvm_srcdir]
     # Note: ShellCommand does not pass the params with special symbols
right.
     # The " ".join is a workaround for this bug.



-- Mikael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131217/a8e73552/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zorg-stdlib-selection.patch
Type: application/octet-stream
Size: 828 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131217/a8e73552/attachment.obj>


More information about the llvm-commits mailing list