[PATCH] Zorg, lld build factory: Remove -stdlib=libc++ as this breaks the GNU build
dblaikie at gmail.com
Tue Dec 17 11:53:57 PST 2013
On Tue, Dec 17, 2013 at 9:21 AM, Mikael Lyngvig <mikael at lyngvig.org> wrote:
> Please? Is there anybody out there? I've tried to get this 15 character
> patch commited for for a week now. My builder has now failed some 225
> builds because nobody has bothered to commit the patch.
Patch review is slow at the best of times - a week is not an extreme amount
of time to wait (indeed we usually recommend new contributors ping a patch
at about a weekly rate, no higher). Though the buildbot config has even
fewer reviewers and Galina is probably the best person to review this as
she contributed the original patch - and I can't say for sure why all those
flags were used for this setup.
All that being said, I committed something that should suffice in r197519,
but I don't know if it'll break other things given the curious set of flags
(strict ansi and libc++) that were specified previously.
> Rui has said "LGTM" about it. Chandler has suggested a change to the
> initial patch which has been implemented in this patch.
> Now I know what I want for Christmas this year! A 15-character patch of
> -- Mikael
> ---------- Forwarded message ----------
> From: Mikael Lyngvig <mikael at lyngvig.org>
> Date: 2013/12/12
> Subject: [PATCH] Zorg, lld build factory: Remove -stdlib=libc++ as this
> breaks the GNU build
> To: LLVM-commits <llvm-commits at cs.uiuc.edu>
> Anyone? My builder keeps failing until this patch is committed.
> Index: zorg/buildbot/builders/LLDBuilder.py
> --- zorg/buildbot/builders/LLDBuilder.py (revision 196862)
> +++ zorg/buildbot/builders/LLDBuilder.py (working copy)
> @@ -57,10 +57,11 @@
> description=["create build dir"],
> cmakeCommand = [
> - "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -stdlib=libc++
> + "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11
> "../%s" % llvm_srcdir]
> # Note: ShellCommand does not pass the params with special symbols
> # The " ".join is a workaround for this bug.
> -- Mikael
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits