[PATCH] [compiler-rt] use .p2align instead of .align
joerg at britannica.bec.de
Sun Dec 15 06:16:19 PST 2013
On Sun, Dec 15, 2013 at 02:10:45PM +0000, Renato Golin wrote:
> Yes, because .align also guarantees that the number is a power of two and
> this is what everyone expects and is used to. You're trying to fix
> something that isn't broken, and will confuse people for seeing raw numbers
> rather than the powers. Feel free to fix the x86 assembly output, but I
> don't think you should change anything else.
I don't agree with this. .align has behavior that differs on different
platforms. That is very confusing for someone moving between different
sources. As such, using .p2align or .balign is really a step forward.
More information about the llvm-commits