[PATCH] [compiler-rt] use .p2align instead of .align
renato.golin at linaro.org
Sun Dec 15 06:10:45 PST 2013
On 15 December 2013 07:08, Saleem Abdulrasool <compnerd at compnerd.org> wrote:
> I had a look at the output, you are right, the i386 version is supposed
> to be aligned to 4. I would like to make the change to the ARM version. I
> realise that this would have no functional difference, but makes it more
> clear that the alignment is meant to be a power of two and not the raw
> value (like the case is for i386). Would you be against that?
Yes, because .align also guarantees that the number is a power of two and
this is what everyone expects and is used to. You're trying to fix
something that isn't broken, and will confuse people for seeing raw numbers
rather than the powers. Feel free to fix the x86 assembly output, but I
don't think you should change anything else.
However, I cannot give you the last word. If there is a strong enough
interest from the community to change all outputs to use .p2align, than by
all means, do so, but unless there is strong consensus, I'd request you not
to change that. You could split your patch to x86 now and leave the ARM
part for later, to expedite the fix you need.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits