[patch] Simplify the datalayout strings by using the defaults
rafael.espindola at gmail.com
Fri Dec 13 11:24:36 PST 2013
On 13 December 2013 11:42, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:
> I've looked at all the strings you changed and I agree that all the changes remove redundantly specified defaults. LGTM.
> By the way, the documentation (at http://llvm.org/docs/LangRef.html#data-layout) doesn't say the default value of <pref> (in i<size>:<abi>:<pref>). It's reasonable to assume <abi> but it ought to say that. Similarly it doesn't say the meaning of <size> (in a<size>:<abi>:<pref> and s<size>:<abi>:<pref>) when it is zero or omitted. Could you add a sentence or two to explain it?
The size is never used. The attached patch updates the documentation
to always omit the size of 's' and 'a' and adds an assert to check
that they are always 0.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2812 bytes
Desc: not available
More information about the llvm-commits