[PATCH] [PATCH][AArch64]Some ACLE pair builtin functions are not handled

Hao Liu Hao.Liu at arm.com
Mon Dec 9 18:01:51 PST 2013

  Hi David,

  You are right. I understand the meaning of code review from your comments.

  Actually, I believe this patch and patch in http://llvm-reviews.chandlerc.com/D2350 will fix the problems and won't introduce any new problems. Both cases are simple and easy to be fixed.

  But I originally thought it was a neccessary process to ask for a code review. And I thought I could commit the patches without approvement if the reviewers are too busy.

  Now I think I understand the meaning of code review. If the patch is very simple, maybe I can commit without code review. If I ask for code review, I should always wait the approvement.



More information about the llvm-commits mailing list