[PATCH] [PATCH][AArch64]Some ACLE pair builtin functions are not handled

David Blaikie dblaikie at gmail.com
Mon Dec 9 11:32:23 PST 2013

Hi Hao,

Generally it's accepted that if you sent code out for review it's
because you aren't comfortable/confident in the change to submit it
with post-commit review. In that case, you are committed to waiting
for feedback to increase your confidence until it is ready to be
committed. Sending something for review, then committed in the absence
of feedback is a red flag - it looks like "I'm not sure about this
patch, but I'm going to push it through anyway because I can't wait
long enough for review".

Is there some reason you originally thought this deserved pre-commit
review but don't believe that's the case anymore?

- David

On Sun, Dec 8, 2013 at 10:41 PM, Hao Liu <Hao.Liu at arm.com> wrote:
>   Committed in:
>   http://llvm.org/viewvc/llvm-project?rev=196749&view=rev
>   http://llvm.org/viewvc/llvm-project?rev=196750&view=rev
>   If anyone have comments, you can have a post-commit review and tell me. I can roll back this patch.
>   Thanks,
>   -Hao
> http://llvm-reviews.chandlerc.com/D2348
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list