[PATCH] Support Android NDK (which has neither futimes nor futimens)

[Alp Toker]

On 07/12/2013 20:59, Rafael Espíndola wrote:
> On 7 December 2013 03:21, Pete Cooper <peter_cooper at apple.com> wrote:
>> Hi Neil
>>
>> Would it be better to make your code execute on any unix platform where
>> those functions aren't available?
> Which are?
>
>> Put it inside the #else and remove the #error
> I disagree. Assuming the direct syscall will work on a system seems
> like the wrong thing to do. People porting llvm to such UNIX system
> are better served by getting the error and then figuring out what the
> proper implementation on their system is.

This needs a cost vs. benefit analysis before going any further...

Cost:
   Maintaining direct Linux syscalls is a burden to the project.

Benefits:
   Adding the syscall may provide command-line users on older Android 
versions some limited support for the llvm-ar tool's obscure -o option 
to preserve timestamps.

On balance, I'd go for making this a no-op :-)

Alp.

-- 
http://www.nuanti.com
the browser experts