[PATCH] Support Android NDK (which has neither futimes nor futimens)

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sat Dec 7 12:59:43 PST 2013


On 7 December 2013 03:21, Pete Cooper <peter_cooper at apple.com> wrote:
> Hi Neil
>
> Would it be better to make your code execute on any unix platform where
> those functions aren't available?

Which are?

>
> Put it inside the #else and remove the #error

I disagree. Assuming the direct syscall will work on a system seems
like the wrong thing to do. People porting llvm to such UNIX system
are better served by getting the error and then figuring out what the
proper implementation on their system is.


Cheers,
Rafael



More information about the llvm-commits mailing list